Skip to content

ci(renovate): add group for Go testing dependencies - #361

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:test-tools-dependencies
Sep 1, 2025
Merged

ci(renovate): add group for Go testing dependencies#361
cert-manager-prow[bot] merged 1 commit into
cert-manager:mainfrom
erikgb:test-tools-dependencies

Conversation

@erikgb

@erikgb erikgb commented Aug 30, 2025

Copy link
Copy Markdown
Member

I propose adding a dedicated group for Go testing dependencies. Some of them, like Ginkgo and Gomega, are released "all the time". So there is no harm in leaving the upgrade PRs open for a while. Or configure them to auto-merge later on, if we considider it safe enough.

Right now, these upgrades might hide (more important) upgrades inside the "Misc Go deps" group. Example: cert-manager/google-cas-issuer#307

@cert-manager-prow cert-manager-prow Bot added the dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. label Aug 30, 2025
@erikgb
erikgb requested review from ThatsMrTalbot and inteon August 30, 2025 10:25
@cert-manager-prow cert-manager-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 30, 2025
@inteon

inteon commented Sep 1, 2025

Copy link
Copy Markdown
Member

/approve
/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inteon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 1, 2025
@erikgb
erikgb force-pushed the test-tools-dependencies branch from fd509fa to 1d4d714 Compare September 1, 2025 16:05
@cert-manager-prow cert-manager-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@erikgb

erikgb commented Sep 1, 2025

Copy link
Copy Markdown
Member Author

@inteon, I have now rebased the branch and resolved conflicts. Do you mind adding another LGTM, please?

@inteon

inteon commented Sep 1, 2025

Copy link
Copy Markdown
Member

/lgtm

@cert-manager-prow cert-manager-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 1, 2025
@cert-manager-prow
cert-manager-prow Bot merged commit c4f8a8a into cert-manager:main Sep 1, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants